Conversation
Contributor
Author
|
Oh boy, looks like another test is failing 😡
... maybe I rushed into merging that WebGL jasmine test PR. |
Contributor
Author
|
another one:
this is getting ridiculous. Starting to feel like reverting #1455 😢 |
Collaborator
|
Yep, lets do it. Gotta get a handle on CI and worry about getting these to work repeatably later. 💃 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... for now. It's been a rough day on CI for those two tests.
I could not find a way to make these tests more robust. Even translating the technique of
gl2d_click_test.jsdidn't work. I think we're not mocking the mouse events that trigger hover in the 3d code correctly. At the moment we're simply triggering a mouseover event. So, let's skip them for now.